fix: Multiple issues with MCP query_(rules/digests)#27
Merged
renecannao merged 5 commits intov3.1-vecfrom Jan 22, 2026
Merged
Conversation
renecannao
commented
Jan 22, 2026
renecannao
commented
- Fixed invalid memory accesses for tables:
- mcp_query_rules
- stats_mcp_query_rules
- stats_mcp_query_digests
- Fixed inactive 'mcp_query_rules' being loaded to runtime.
- Fixed hash computation in 'compute_mcp_digest'.
- Fixed invalid escaping during 'stats_mcp_query_digests' gen.
- Fixed digest generation for MCP arguments:
- SQL queries are now preserved using 'mysql_query_digest_and_first_comment'.
- TODO: Options for the tokenizer are right now hardcoded.
- Added initial testing and testing plan for MCP query_(rules/digests).
- TODO: Test finished on phase8. Timeouts destroy the MCP connection, leaving it unusable for subsequent queries this should be fixed for continuing testing.
- TODO: There are several limitations to fix in 'validate_readonly_query'. This reflect in some query hacks in the testing.
- 'SELECT' starting with comments (--) gets flagged as non-read.
- 'SELECT' must have a 'SELECT .* FROM' structure. While common, simple testing queries many times lack this form.
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.